Have you read the Code of Conduct? By filing an Issue, you are expected
to comply with it, including treating everyone with respect:
Remember that these are some guidelines, use your best judgement.
Description
[Description of the issue]
When there are multiple repos enabled and more than one repo has the same name for a plugin(File Size Metrics Data Panel), installing one plugin then displays as both are installed.
This will cause issues if the plugins are different versions, triggering a "update available" if the plugin installed is a lesser version number to the other plugin. It will see the same named plugin and its higher version as an update to what is installed.
This could also be a security issue, as one valid plugin could be hijacked by a plugin from another repo without the user being aware, if they run the "update"
Steps to Reproduce
[First Step]
install Espadav8s repo
[Second Step]
install the File Size Metrics Data Panel from the official repo
go to plugin page and see an update available for the official plugin, from Espadav8s repo.
Expected behavior: [What you expect to happen]
Plugins to be tracked by name or id and repo, to determine a plugin is unique
Actual behaviour: [What actually happens]
Plugins are thought to be the same, even if from different repos
Reproduces how often: [What percentage of the time does it reproduce?]
100%
Versions
Version: 0.2.4~7339f8b
The version can be found at the footer of the WebUI. Also, please include the OS details and what version you are running
(e.g. cat /etc/os-release).
Installation Method Used
Manually installed and run or run through Docker?
Additional Information
Any additional information, configuration or data that might be necessary to
reproduce the issue.
Have you read the Code of Conduct? By filing an Issue, you are expected to comply with it, including treating everyone with respect:
Remember that these are some guidelines, use your best judgement.
Description
[Description of the issue] When there are multiple repos enabled and more than one repo has the same name for a plugin(File Size Metrics Data Panel), installing one plugin then displays as both are installed.
This will cause issues if the plugins are different versions, triggering a "update available" if the plugin installed is a lesser version number to the other plugin. It will see the same named plugin and its higher version as an update to what is installed. This could also be a security issue, as one valid plugin could be hijacked by a plugin from another repo without the user being aware, if they run the "update"
Steps to Reproduce
Expected behavior: [What you expect to happen]
Plugins to be tracked by name or id and repo, to determine a plugin is unique Actual behaviour: [What actually happens] Plugins are thought to be the same, even if from different repos
Reproduces how often: [What percentage of the time does it reproduce?] 100%
Versions
Version: 0.2.4~7339f8b The version can be found at the footer of the WebUI. Also, please include the OS details and what version you are running (e.g.
cat /etc/os-release
).Installation Method Used
Manually installed and run or run through Docker?
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.