Unmanic / unmanic

Unmanic - Library Optimiser
GNU General Public License v3.0
1.66k stars 82 forks source link

Plugin MKVPropEdit tags fail vaidation on plugin list #487

Open OmegaModr opened 5 months ago

OmegaModr commented 5 months ago

Have you read the Code of Conduct? By filing an Issue, you are expected to comply with it, including treating everyone with respect:

Remember that these are some guidelines, use your best judgement.

Description

On a fresh install when trying to install plugins form the official repo json validation fails.

[ "Traceback (most recent call last):\n", ' File "/usr/local/lib/python3.10/dist-packages/unmanic/webserver/api_v2/plugins_api.py", line 697, in get_installable_plugin_list\n response = self.build_response(\n', ' File "/usr/local/lib/python3.10/dist-packages/unmanic/webserver/api_v2/base_api_handler.py", line 123, in build_response\n raise exceptions.ValidationError(validation_errors)\n', "marshmallow.exceptions.ValidationError: {'plugins': {4: {'tags': ['Not a valid string.']}}}\n" ]

Steps to Reproduce

  1. Run unmanic docker
  2. Go to plugins -> install plugins
  3. Get an empty list

Expected behavior: [What you expect to happen]

-the json object is not formated as unmatic expects { "author": "mmenanno", "compatibility": [ 2 ], "description": "Run MKVPropEdit on a file", "icon": "https://upload.wikimedia.org/wikipedia/commons/2/21/Mkvmerge256.png", "id": "mkvpropedit", "name": "MKVPropEdit", "priorities": { "on_worker_process": 0 }, "tags": [ "command", "mkv", "tweaks" ], "version": "0.0.1" },

Manually formatting as

"tags": "command,mkv,tweaks", in the cached json lists the plugins as it should.

Actual behaviour: [What actually happens]

Reproduces how often: [What percentage of the time does it reproduce?]

100%

Versions

0.2.7

The version can be found at the footer of the WebUI. Also, please include the OS details and what version you are running (e.g. cat /etc/os-release).

Installation Method Used

Manually installed and run or run through Docker? Docker

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.