search

UnnoTed / fileb0x

a better customizable tool to embed files in go; also update embedded files remotely without restarting the server
MIT License
634 stars 53 forks source link

"Base" option stopped working #9

Closed andreynering closed 7 years ago

andreynering commented 7 years ago

Hi,

Seems that https://github.com/UnnoTed/fileb0x/commit/5494112a4d3e8629069278b3b0125960cd699c8d changes the behavior of base.

I have something like this:

custom:
  - files:
    - "public/js"
    - "public/css"
    base: "public/"

Before that commit, I could serve files as /js/... and /css/... instead of /public/js/. But now public/ is not being removed from the path anymore.

Thanks for this awesome lib.

UnnoTed commented 7 years ago

Hi, I couldn't reproduce.

Take a look at: https://github.com/UnnoTed/fileb0x_issue9

andreynering commented 7 years ago

Hmm...

I yesterday night tried this repo on Linux and it worked fine.

But I now tried on Windows and the problem happens.

See https://github.com/andreynering/fileb0x_issue9/commit/9ad872bdd6a9bf10dbbd9181203cd6328eca6dd1

andreynering commented 7 years ago

Fix here: https://github.com/UnnoTed/fileb0x/pull/10

UnnoTed commented 7 years ago

Merged, thanks!