Uno-Re / unore-uno-dao

0 stars 0 forks source link

[I-01] Pragma statement #17

Open madMax92221 opened 10 months ago

madMax92221 commented 10 months ago

The pragma statement is different almost everywhere. Some contracts are using floatable pragma. Every version after 0.8.19 will use the PUSH0 opcode, which is still not supported on some EVM-based chains, for example Arbitrum. If the protocol is expected to be deployed on multiple EVM-based chains (Optimism, Arbitrum, Polygon etc), that will be problematic.

Consider using version 0.8.19 so that the same deterministic bytecode can be deployed to all chains.

Even if the protocol is not expected to be deployed on multiple EVM-based chains, always use stable pragma statement to lock the compiler version and to have deterministic compilation to bytecode.

wankhede04 commented 9 months ago

fixed at commit https://github.com/Uno-Re/unore-uno-dao/commit/63aa5cfd5580d45f12ae88a55d1daa93cf69392d