search

UnoffLandz / unoff-landz

open source server for the eternal lands/other life client
9 stars 4 forks source link

This is preliminary work on #59 #61

Closed nemerle closed 9 years ago

nemerle commented 9 years ago

I've moved all database related files into a 'db' directory to clean up the project dir a bit

I'd welcome some code/project review on the changes ( especially the '-std=c99' change to compiler settings)

themuntdregger commented 9 years ago

Hi Artur

Have merged your pull request and really like what you've done.

I have no problems building an executable using -std=c99, so all looks good. It even highlighted where i'd mistakenly used an int16_t datatype. I've got a couple of compiler warnings - passing argument 6 of ‘log_sqlite_error’ discards ‘const’ qualifier from pointer target type on your new database functions, but nothing serious.

Haven't yet tried to compile the client.

On 15 April 2015 at 11:24, Artur K. notifications@github.com wrote:

I've moved all database related files into a 'db' directory to clean up the project dir a bit

I'd welcome some code/project review on the changes ( especially the

'-std=c99' change to compiler settings)

You can view, comment on, or merge this pull request online at:

https://github.com/UnoffLandz/unoff-landz/pull/61 Commit Summary

  • move all database related code into separate directory
  • Starting work on #59

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/UnoffLandz/unoff-landz/pull/61.