search

UnofficialCrusaderPatch / UCP3-GUI

Dev work on the UCP3 gui
GNU Affero General Public License v3.0
0 stars 0 forks source link

Changing Extension order makes config-full and config-sparse go out of sync #202

Open gynt opened 5 months ago

gynt commented 5 months ago

Use 3 non co-dependent extensions to reproduce

Likely issue: extension order is only saved to config-full, but read from config-sparse.

gynt commented 4 months ago

Turns out the order is saved appropriately to the full config, but refreshing the UI does not reproduce that order. It seems to prefer a different order altogether, maybe dictated by lean-resolution?

Yes loading is done from config-sparse, in import-button-callback, since it should be able to handle slight version differences on the end of the user, which means the config-full load order cannot be trusted 100%. Solution A: trust config-full load order 100% until any (version) error is encountered and if so fall back to rebuilding the list from the config-sparse load order Solution B: build from config-sparse load order first, and then try impose the full-config load order on it.

gynt commented 1 month ago

@Krarilotus reported he experiences this issue (again?)

Krarilotus commented 1 month ago

Example of something that could have to do with this, i am not 100% sure, but its super confusing: i have this setup: image Then i click right Legends of the Orient extension, getting this result: image clicking right the Krarilotus-aggressive-AIC next: image

Problem: The GUI does not save the order which i had my plugins before a change occurred, making everything i can setup obsolete and i will have to redo things if i changed the order. Same is also true for completely unrelated extensions (if you think it was just because aggressive behaviour is part of vanilla retraced), like say the time-provider plugin. Anything put to the right side reshuffles the extensions previously setup in the 'intended' order into a now kinda artificially ordered order i assume, as the new order is always the same for the same previous plugins, regardless of what i changed in their order before.

So i guess the problem isn't fixed, as the changes made in the order are not yet saved to the config, that is loaded on any possible occasion that the config is loaded or updated.

gynt commented 1 month ago

This is a different issue, but a nice report, I will refer to it in a new one