search

UnofficialCrusaderPatch / UCP3-GUI

Dev work on the UCP3 gui
GNU Affero General Public License v3.0
0 stars 0 forks source link

[CONTENT_TAB] Version selection of activated extensions is either not useable or visible #219

Open TheRedDaemon opened 3 months ago

TheRedDaemon commented 3 months ago

grafik

I do not know the plan: Should a change of the modules version still be possible if it is selected? If yes, then the arrows need to work or indicate that they do not work (and may even need to exclude/deactivate the versions that do not work).
If no, then the dropdown arrows for the versions should not be displayed.

gynt commented 3 months ago

No a change to the modules version should not be possible when it is activated. Hiding the arrows is the way to go.

Krarilotus commented 1 month ago

Why should the change not be possible, how do i update an extension with many nested dependencies to a new version easily then?

gynt commented 1 month ago

That should be a separate button, something with a reload/refresh icon, which would trigger an upgrade logic to update your active extensions to the latest versions, retaining configuration.

Krarilotus commented 1 month ago

but the question stays: Woudn't we need a way to select specific versions for active extensions? Or why does that not work?

gynt commented 1 month ago

When an extension is selected for activations, its options and config are processed. Those two are tied to a version of an extension: a future version and add options. Or a 2.0.0 of an extension can remove options (i.e., breaking changes). Upgrading an extension while it is active can become an involved process if the underlying config and options changed.

I think changing an extension version while it is active is unclear to people who like customizing: options disappear, or options are added silently. The version dropdown is part of a selection process: which exact version do you want to activate? Rather than an or downgrade upgrade process.

Now, in the case of selecting specific versions of dependencies (let's call dependencies children), that can be done by using the version dropdown, activating the dependency, and then activating the parent extensions. This will force the usage of a specific version of a dependency.

Can you describe the use case for what you want?

Krarilotus commented 1 week ago

I think your point is valid, but for the updateability there is now the seperate issue, which number i can't find on the phone ^^ So when in editing mode maybe i could still see why it makes sense for a creator to easily change the version of a dependency of their own other subplugin, without loosing all their settings for that plugin by removing it first.

gynt commented 1 week ago

Should be a separate feature for editor mode then! That makes sense