UnofficialCrusaderPatch / UnofficialCrusaderPatch2

Unofficial balancing patch installer for Stronghold Crusader 1
MIT License
430 stars 59 forks source link

Ally color in allied menu #503

Open LordHansCapon opened 4 years ago

LordHansCapon commented 4 years ago

Sadly, my fix for the palyercolor in allied menu is not 100%. I noticed that if an AI's color was anything but black, it doesn't work. This is due to the text color having different IDs. For example, for black, it was 6 (not 5), and for blue, it was 2 (not 4). I will fix that bug in another pull request.

GRhin commented 4 years ago

Would it be simpler to swap the colour the I'd refers to?

LordHansCapon commented 4 years ago

@GRhin Sadly no, the player ID, colors and text colors are all over the place.

Sometimes the order is:

It is possible to map all these and search for every single render point, but there are hundreds of them because the code render function is reused, but the calls for the functions are varying a lot.

Admiral-Gumpert commented 4 years ago

Emblem color and AI shield are still not fixed , Am I doing anything wrong or the code block didn't get fixed ?

LordHansCapon commented 4 years ago

@Admiral-Gumpert It has not been merged ye , nor was a release created since my fix. You can build it from this repo: https://github.com/LordHansCapon/UnofficialCrusaderPatch

Or if you can't build it, check out this thread, there is a wetransfer link with the build: https://github.com/Sh0wdown/UnofficialCrusaderPatch/issues/504#issuecomment-577852154

Admiral-Gumpert commented 4 years ago

@Admiral-Gumpert It has not been merged ye , nor was a release created since my fix. You can build it from this repo: https://github.com/LordHansCapon/UnofficialCrusaderPatch

Or if you can't build it, check out this thread, there is a wetransfer link with the build: #504 (comment)

I have just updated the zip file and everything works fine , Tested all the 7 colors and they just work fine even in Extreme version !

GRhin commented 4 years ago

Can be closed with new release