[MODULES/UCP_2] Judge/Port/Test all UCP 2 features

[TheRedDaemon]

Now, at the time of writing this, a lot of the features have been ported, but some are still missing, some are still not really tested, etc. This issue is intended to collect the current progress towards UCP 3.0.0.

Please let me know the status in the comments, so that I can update it.

The checkboxes are for stuff that still needs discussion. If they are checked, the point is done. Note, that this only refers to the implementation of the functionality. Proper option structure (the possiblity to set values should be present however), documentiation, etc. are not important for this issue.

Intended for port

The statuses are ❔ (open, unknown), ⚠️ (needs testing, in testing), ✔️ (functional) and ❌ (broken) and are placed behind the checkbox but before the feature text. The 🚧 icon is used for features that were in the dev branch of UCP2 but never made it to a UCP2 release (even though they may work).

• [ ] ⚠️ Bugfixes
  • [x] ✔️ Fix ladder climbing destination bug
  • [x] ✔️ Fire ballistae shoot monks and tunnelers
  • [x] ✔️ No demolishing of inaccessible buildings
  • [x] ✔️ Fix reinforcement of defense troops
  • [x] ✔️ Disable ox tether spam
  • [x] ✔️ Buy enough wood
  • [x] ✔️ No limit for siege engines on towers
  • [x] ✔️ No AI target change during sieges
  • [x] ✔️ Improved AI repairs
  • [x] ✔️ Fix AI not using laddermen if they are enclosed
  • [ ] ⚠️ 🚧 Fix resources rapid deletion
  • [x] ✔️ Reset lord animation after destroying buildings
  • [x] ✔️ Fix apple farm worker getting blocked
  • [x] ✔️ Fix tanners getting all the same cow
  • [x] ✔️ Fix fletcher pathing
  • [x] ✔️ Fix AI's crusader archers not lighting pitch
  • [x] ✔️ Fix bakers despawning
  • [x] ✔️ Fix despawning of digging units
  • [ ] ❔ 🚧 Stop jester from visiting assassins
  • [x] ✔️ 🚧 Enable map sending in multiplayer
• [ ] ⚠️ AI Lords
  • [x] ❔ Improve AI restocking of needed goods
  • [x] ⚠️ Let the AI build houses smarter
  • [x] ⚠️ Set AIs initial time until they recruit by the AIC parameters
  • [x] ⚠️ Increase of the attacking troops limit of the AIs
  • [x] ⚠️ Improve attack waves
  • [x] ⚠️ Set attack target
  • [x] ⚠️ Disable sleeping mode for lack of resources
  • [x] ✔️ Deactivate demolishing for money of the AI lords
  • [x] ⚠️ Increase of the rate of additional attack troops
  • [x] ⚠️ Increased recruitment speed
• [ ] ⚠️ Units
  • [x] ✔️ Increased armor of laddermen against ranged units
  • [x] ✔️ Increased armor of Arabic Swordsmen against crossbows
  • [x] ✔️ Arabic Swordsmen destroy walls faster
  • [x] ✔️ Increased armor of spearmen against ranged units
  • [x] ✔️ Restore engineer arabian speech
  • [x] ✔️ Spearmen run by default instead of walking
  • [ ] ⚠️ 🚧 Priest range restriction
  • [ ] ⚠️ 🚧 Priest range check
• [ ] ⚠️ Other
  • [x] ⚠️ Extend fireproof duration of extinguished buildings
  • [x] ✔️ Removes the magic bar in Crusader Extreme
  • [x] ✔️ Change the color of player 1
  • [x] ✔️ WASD-Keys and quicksaves
  • [x] ✔️ Override the Set-up Identity menu adding new features
  • [x] ✔️ Healer heals casualties
  • [x] ✔️ Free trader post
  • [x] ✔️ No siege tent deselection
  • [x] ✔️ Always show planned moat
  • [x] #63
  • [x] ⚠️ Quicker responsiveness of gates towards enemies
  • [x] ✔️ Activate Spectator-mode
  • [x] ✔️ Fix armory/marketplace weapon orders to match
  • [x] ✔️ Check more often for available paths
  • [x] ✔️ Set default multiplayer speed
  • [x] ⚠️ Strongholdify
  • [x] ✔️ Shrink apple orchard's build size
  • [x] ✔️ Spawn siege engines in the center of the tent
  • [x] ✔️ Rotate player keeps same as AI
  • [ ] ❔ 🚧 Remove right click context menu
  • [x] ⚠️ Fast Placing
  • [ ] ⚠️ Disable border scrolling
• [x] ✔️ Start goods (separate module)

• [x] ❔ Start troops (separate module)

  Superseded

  Old features that are now provided by other modules and therefore need no porting.

  • [ ] Any AI specific feature like AIC/AIV -> Now provided by the AI Swapper

Not ported

This section are for features that will not be ported for the 3.0.0 (!), for whatever reason (too difficult, not needed, etc.).

• [ ] #64

Notes

• Are there still features missing, maybe some updates past version 2.15b?

Edits

1. Moved all so far to testing status, since options for all of them seem to be present.
2. Added test results by LeSpec from HERE, ignoring the "marketplace_weapon_order_fix", because it has apparently issues.
3. Added test results of THIS comment and added status of features present in the UCP 2 development version.
4. Updated test results with content of THIS comment.
5. Updated test results with content of THIS comment.
6. Updated test results with content of THIS comment.

[Krarilotus]

Active spectator was tested and worked Gamespeed limits tested and working Ox tether fix tested and working Shrink apple orchards build size works too Free trade post worked Removing magic bar worked

What are priest range restriction and priest range check, both havent been present in the current 2.15b testing build

Features missing from the current 2.15b test build:

• restocking goods periodically
• rapid building of structures
• rapid deletion bugfix

Maybe more but i can't list them out of my head right now, will post when i get the chance to look at it :) -> in the meantime, you can also check, because some options of previous features are missing from the condig files Download the newest build from the old repo and run it, chec for options and features that havent yet been ported.

[TheRedDaemon]

Comment to collect testing done by @TheRedDaemon:

• "Reset lord animation after destroying buildings" appears to be working. Tested in SHC 1.41 and 1.41.1-E.
• "Fire ballistae shoot monks and tunnelers" works. Tested in SHC 1.41 and 1.41.1-E.

[Krarilotus]

Features tested 10th November

• fixing laddermen forgetting destination bug: ✔️
  • tested in map editor with laddermen and spearmen
  • tested also with archers and macemen, to climb up and down over multiple layers of wall
  • doesn't enable to 'attackcommand' over ladders to a destination, likely still buggin out the AI if there is no direct path after the ladder to attack someone
  • Also tested in extreme
• no demolishing of inaccessible buildings: ✔️
  • tested deletion of inaccessible buildings by AI, works in normal Cruasder
• deactivate demolishing for money, if enclosed: ✔️
  • tested together with the inaccessible buildings to make sure. Blocked gates with woodcutters and the AI did not delete all its outside eco, so it worked for me (tested in normal crusader with Sultan)
• Fix reinforcement of defense troops: ✔️
  • tested in normal Crusader, Sultan reinforced his walls with new sligners after they got shot, even though he still had outside patrols running!
• No limit for siege engines on towers: ✔️
  • tested with wolf and abbot in normal Crusader, wolf building more than 3 trebuchets and abbot more than 3 tower ballistas
• Buy enough wood: ✔️
  • tested in normal Crusader, wolf and abbot bought always to have 2 extra wood left after building something out of wood

[Xander10alpha]

Features tested 24th November

• "No AI target change during sieges" Test in SHC + SHC-E Skirmish Battels worked in both. Test with 4 Snakes because there are all Balanced and it change quit often who is Last but if one Snake attack another snake it chnage from Last place to 3 or 2 and the attack don't retarget.
• "Improved AI repairs" Test in SHC + SHC-E Skirmish Battels worked in both. Test it with 2 Richard against 2 Fredericks and if the Towers was broke (Stump) they build the Tower new.
• "Fix apple farm worker getting blocked" Test in SHC + SHC-E Skirmish Battels worked in both
• "Fix fletcher pathing" Test in SHC + SHC-E Skirmish Battels worked in both
• "Fix AI's crusader archers not lighting pitch" Test in SHC + SHC-E Skirmish Battels worked in both
• "Fix bakers despawning" Test in SHC + SHC-E Skirmish Battels worked in both
• "Fix despawning of digging units" Test in SHC + SHC-E Skirmish Battels and in the Map Editors worked in all

[Krarilotus]

How did you test the retargeting and the repairs exactly? @Xander10alpha

[Krarilotus]

ticked all the boxes that we checked, however there is still an issue with the aiSwapper, even autosave in multiplayer crashed the game.

• the rapid deletion bug we coudn't check if it works because noone of us can click this fast (need professional player)
• the disable border scrolling acn be moived to not ported, as it conflicts with the Grafics API replacer and can cause issues together
• the priest change was not in UCP2.15b dev branch and needs to first be introduced
• stop jester from visiting assassins isnt implemented yet