UnofficialCrusaderPatch / extension-aicloader

Module for the UCP framework to customize AIC's
0 stars 1 forks source link

Reconsider changing isPositiveInteger to isIntegerValue for AIC values that permit cheating #10

Open gynt opened 1 month ago

gynt commented 1 month ago

@Krarilotus

gynt commented 1 month ago

The question is, should people be able to cheat?

Solution: warning for invalid values, no errors.

Logic:

  1. Validate for impossible values, throw fatal errors
  2. Warn for cheat values (negative integers), place warnings in the logs (or popups on preference?)
  3. Set the value
Krarilotus commented 1 month ago

For now, i would say we should mimic the behaviour of the old UCP as close as possible, that way people just get what they expect, and add all the fancy shenanigans on top later. -> Hence i would suggest switching all checks for positive integers to normal integers for now, until we have a proper way of handling this, so AIs work as expected!

gynt commented 1 month ago

Partly done in the PR (#14) for fields that haven relevant negative values.