search

UnownHash / Fletchling

10 stars 3 forks source link

Add options to filter contained #16

Closed comstud closed 6 months ago

comstud commented 7 months ago

This is quick and dirty and seems fine. Better than nothing, anyway.

This adds the option to allow contained (disabled by default) to both the importer and fletchling. The importer will not import the contained nests at all if left disabled. fletchling will double check things being loaded from the db on startup/reload in case one does import everything. Should be fast enough.

This doesn't fully check contained, but does check the label point within is contained by another. I think this is good enough for now, at least.

Fixes #11

comstud commented 7 months ago

This seems to work. Maybe should be moved to be after the area and/or spawnpoint filters. And I should fix up the loading into the containsMatcher. It's loading more than it needs to and this is maybe taking a while for some. :)

comstud commented 7 months ago

I'm sorta now thinking that fletchling itself shouldn't do this but it should be left to other tools, like the importer, and then something else to manipulate the db outside of fletchling for when you want to change your active nests in the DB.

lenisko commented 7 months ago

Yeah, leave it for importer IMO. Ideally, we would run it manually after changes or ~once per week to fill anything new. Doubt most will use anything else than those internal tools.

comstud commented 7 months ago

Yeah, leave it for importer IMO. Ideally, we would run it manually after changes or ~once per week to fill anything new. Doubt most will use anything else than those internal tools.

Yup. Going to fix this up later tonight.

comstud commented 7 months ago

Pushed a commit to remove from fletchling. Doesn't do the other things yet. Going to try to sleep early. only 1:30am :)

comstud commented 7 months ago

Work here will have to wait another night. I'm going to need the 'config moving' part from the poracle PR that just went up. I may merge that even without testing it. If it's broken, just don't configure it. :) But not tonight. Maybe I'll feel like testing it first tomorrow, who knows. Rather tired now.

comstud commented 7 months ago

Likely just going to abandon this branch for something different. But I have run out of time again tonight.