do not make gbl leagues configurable

[ccev]

there is no point. it's only clutter

my suggestion:

[pvp]
enabled = true
include_hundos_under_cap = false
level_caps = [50, 51]
process_ultra = true
process_great = true
process_little = true

old:

[pvp]
enabled = true
include_hundos_under_cap = false
level_caps = [50, 51]

[[pvp.leagues]]
name = "little"
cap = 500
little = false

[[pvp.leagues]]
name = "great"
cap = 1500
little = false

[[pvp.leagues]]
name = "ultra"
cap = 2500
little = false

[jfberry]

agreed with this when you first said it; only time has prevented me from removing these from config

[ccev]

@TurtIeSocks @Mygod I see you're downvoting this. Why do you think leagues should be configurable?

[TurtIeSocks]

• Ohbem, both JS and GO versions, are built to support a dynamic configuration, why hardcode it?
• Niantic could add or change a league at any time, some of which people may or may not care about. Most people didn't care about little for a very long time, now it's generally "standard". I don't think we should have to update the codebase or force these types of changes on all users.
• RDM and ReactMap supports the same level of configuration. If we want Golbat to be used by the masses and the work has already been done, why throw it away? It's all just a terrible json saved in the db anyway.

In the end, are we losing performance by having it be configurable?

That being said, I would be in favor of having a "smarter" default, so we could remove it from the base/example config and people would still get the base 3 leagues. Then if they do add it to their config, it would overwrite the provided default.

[ccev]

The point is that since the introduction of PVP, only a single league has ever been added, that being little. For the off chance this would ever happen again, it would be a lot easier to just update everything rather than having to go through every config and changing it yourself.

Other tools doing it is no reason to keep doing it. That's the entire point of all this.

[Fabio1988]

Forcing people to use latest up to date version 😃

[Mygod]

Okay on second thought I guess since Golbat is user facing (instead of Ohbem being a library), it makes sense to simply force updates with reasonable defaults.

But I still disagree that it would just be clutter. Some Golbat user might want to turn off processing little cups to save RAM/disk IO; some might want to process little cup only for unevolved Pokemon rather than all possible evolutions (the 2 little cups in the current season does enforce this); some might want to turn off BB level cap (level 51) (while you could care about this, I personally don't know anybody that actually uses a best buddy rank 1 in GBL other than perfects like Umbreon or Galarian Stunfisk in ultra league). Sure if everyone has infinite RAM/disk IO/CPU then we should turn on everything but we do not live in an ideal world. :)

[Mygod]

As another example, perfect Talonflame at Lv50 hits CP2493, and is technically strictly worse than 14/14/14 or 14/15/13 at Lv51 (having +0.11 attack, and either +0.85 defense or +1 HP); but it will actually win the CMP tie against Lv51 rank 1 13/15/15 as higher stat product usually has lower attack. Therefore, it is usually better to use a perfect Talonflame and save the BB slot for something else like Umbreon/Galarian Stunfisk where BB will give you a larger gain (improving all 3 stats).

[ccev]

I'm not into the specific of PVP, but I agree on leaving most things configurable (inlcuding toggling processing of the different leagues), the issue was more about removing the actual league definitions (i.e. saying there's a great league with a 1500cp cap)

[ccev]

I have updated the description with a suggestion for how the config section should look like

[lenisko]

I'm OKAY with removing it from config.toml.example but this still should be configurable and set as correct defaults inside Go. Don't take configuration from users, make a note that if something was changed and is not documented inside config.toml.example or other place, user is on his own when reporting errors. Simple as that. Less configuration options = less friendly software = more forks.

[Mygod]

I agree that the clutter is not too bad. Anyway I'm okay with either keeping as is, or the new proposed solution if we add a little_filter toggle.

[jfberry]

I like the example you have provided; my idea for this wasn't actually to include the little, great, and ultra as options but assume that all those would be provided. Only to specify whether little league non-evolution rules were applied (which is what little flag does right now)