UnravelSports / unravelsports

The unravelsports package aims to aid researchers, analysts and enthusiasts by providing intermediary steps in the complex process of turning raw sports data into meaningful information and actionable insights.
Mozilla Public License 2.0
42 stars 1 forks source link

Misspell in 'examples/1_kloppy_gnn_train.ipynb' #1

Closed ThiagoBorges81 closed 3 months ago

ThiagoBorges81 commented 3 months ago

Hello, Joris.

Quite interesting library you have here. I was taking a look around and found a misspell here:

file location: "examples/1_kloppy_gnn_train.ipynb"

Where the mistake is:

"6.3 Build GNN Model

This GNN Model has the same architecture as described in A Graph Neural Network Deep-dive into Successful Counterattacks {A. Sahasrabudhe & J. Bekkers}

This exact model can also simply be loaded as:

from unravel.classifiers imoprt CrystalGraphClassifier as shown in Quick Start Guide"

In the last line where you explain how to import CrystalGraphClassifier, it says "imoptr".

Hope this helps.

Cheers

Thiago

UnravelSports commented 3 months ago

Hi @ThiagoBorges81, very good eye! I've fixed it, thank you.

If you find anything else, feel free to let me know.