search

Unreal-Dan / RekordBoxSongExporter

A hack for Rekordbox on Windows x64 to export track information for realtime integration with OBS
63 stars 6 forks source link

Same bug - unexpected crash #24

Closed musicalnerd closed 10 months ago

musicalnerd commented 1 year ago

Hi Dan,

The trackid works with 6.7.5 but it still crashes on first track loaded if deck 1. I'll attach the error log (i managed to make it crash 3 times, trying loading from a different deck. It seems that if you manually set a deck to "master" before the track starts playing with the fader up, it seems to crash.

Frank

Unreal-Dan commented 1 year ago

ah interesting, I'll take a look.

Just to confirm, does this prevent you from using it? Or is it just an edge condition use case?

musicalnerd commented 1 year ago

Rekordbox crashes if you click OK on the error message. I haven't tried to ignore the error given it's while i stream; didn't want to risk it. The DMP files can't be loaded here sorry

Unreal-Dan commented 1 year ago

You can email the dmp file to my gmail, unrealdanmail on gmail, that might help me out. Thanks

Unreal-Dan commented 1 year ago

It seems to be related to the bpm, are you using bpm tags? Can you post your tags?

This is definitely a bug that only you are facing and I cannot reproduce it, the dmp files helped and pointed me towards %bpm% but I cannot reproduce the crash in the same place and I'm not sure why.

Are you using a streaming service to load your tracks? Or are they files on the disk?

Does this happen with every single track? Or is it perhaps only specific tracks?

musicalnerd commented 1 year ago

Hey Dan,

i'm using Tidal streaming for the tracks (FLAC format if it helps). For the tags, i'm using :

%rt_master_bpm% and %bpm% . I can revert to %master_bpm% and try to see if it still crashes.

It happens whenever i start the hack , automatic crash doesn't matter what track but i sense having a "master RT" might be the issue since you can't trigger a change of BPM on the very first track might be why. Frank

On Mon, Oct 16, 2023 at 11:52 PM Unreal-Dan @.***> wrote:

It seems to be related to the bpm, are you using bpm tags? Can you post your tags?

This is definitely a bug that only you are facing and I cannot reproduce it, the dmp files helped and pointed me towards %bmp% but I cannot reproduce the crash in the same place and I'm not sure why.

Are you using a streaming service to load your tracks? Or are they files on the disk?

Does this happen with every single track? Or is it perhaps only specific tracks?

— Reply to this email directly, view it on GitHub https://github.com/Unreal-Dan/RekordBoxSongExporter/issues/24#issuecomment-1765620935, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARALG3EJWGNC3HF6MXEERCDX7X6IPAVCNFSM6AAAAAA5VCNASSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRVGYZDAOJTGU . You are receiving this because you authored the thread.Message ID: @.***>

Unreal-Dan commented 1 year ago

it seems the crash was related to the propagation of a %bpm% update, and it's quite possible that is a result of using a track from tidal...

Try loading a track that exists on your local filesystem and see if it still crashes, I may need to do some testing with tidal to get that working.

Wietjuh commented 1 year ago

I noticed if you click master before track load it doesn't crash, i've had it with al kinds of files, but ever since i click master before track load it holds up nicely. Also i've disabled the bpm tag completly.

Maybe this will help troubleshooting.

I could A/B test coming days, i'll come back to this

musicalnerd commented 1 year ago

I noticed if you click master before track load it doesn't crash, i've had it with al kinds of files, but ever since i click master before track load it holds up nicely. Also i've disabled the bpm tag completly.

Maybe this will help troubleshooting.

I could A/B test coming days, i'll come back to this

Hey, you might be on to something, i gave it a shot and when you look at the output file (i made one that tracks everything from the start) and it looks like this (i;ve forced master deck on 1, before loading a tidal track in)

    (00:00:00),,by,, 
    (00:00:05),Acheron (Original Mix),by,2Pole,5A 
    (00:00:37),Decipher,by,A.D.H.S.,8B

It indeed did not crash using that little workaround Frank

Unreal-Dan commented 1 year ago

That's quite interesting, I wonder what is happening... At the very least I should be able to harden against this so it doesn't crash.

Wietjuh commented 1 year ago

I'm on a holiday now, but ever since disabling bpm and I click Master before load it works for me.

Even tho I'd love the bpm function, it should not let the program hard exit and force close RB.

If I can do any logging or testing for you to reproduce, let me know

Unreal-Dan commented 1 year ago

I suspect removing %bpm% is the main reason you don't crash, but selecting the master likely also has something to do with it.

I agree, even if perhaps the first bpm fetch fails it should not outright crash the program and I should be able to find a way around it.

The main problem is I don't have tidal so I can't reproduce this bug, I haven't looked recently but what I recall is it only happened with tidal tracks + the %bpm% tag.

Can you confirm whether it happens for any other kinds of tracks? Specifically, does it happen for any tracks you have on your local PC as a file? Or does it only happen with tracks from tidal?

Wietjuh commented 1 year ago

I had the same issue with local files, but had it in the past (since 6.0.1 rb) with Tidal and Beatport tracks when they didnt load up quick enough. And I also assume that it only stores the database entry (the tracks are filenames TIDAL:2646282)

I also know they don't send the bitrate and filesize decently.

If you need anything, like logs or something, let me know, I'll post when I'm back home after my holiday

Unreal-Dan commented 11 months ago

Okay I don't know what the problem is, I also didn't really investigate, but I don't want to keep you guys waiting forever.

I do know the issue is related to BPM so I have hardened some code around fetching the BPM with the hope that it might prevent the crash, but I need one of you to test it.

I've built a custom version of RBSE 3.8.2 which uses this additional hardening around the BPM fetch.

Could one of you please test this and see if you can get it to crash with %BPM% on the tidal tracks? RekordBoxSongExporter3.8.2-TEST.zip

Wietjuh commented 11 months ago

I'll have a test tomorrow, should I enable logging or collect something?

Unreal-Dan commented 11 months ago

Nah just try to make it crash, if it doesn't crash then success. If it does crash then I'll have to try some other things. Ultimately I'm just trying to put a bandaid on the issue and not really trying to fix it right now

Wietjuh commented 11 months ago

So far so good, I think this should've done the trick. Testing out master bpm right now one more time

DeejScorpio commented 11 months ago

Hey Dan, first off love the app..truly amazing mate. I just wanted to let you know I am getting the same crash when using the BPM tags. Here's my experience:

Weird thing is, is if I do not have my computer hooked up to my controller, the BPM tag works fine. Only when I am hooked up to it does it crash. (Running a DDJ-1000)

Cheers again!

Unreal-Dan commented 11 months ago

Thanks I'm glad this could be of use to people.

Interesting, seems you have different results from Wietjuh?

Do you get a crashdump? Could you send it to unrealdanmail on gmail I'll take a look and see where the module is crashing and see if I can bandage it the same.

DeejScorpio commented 11 months ago

Shot it over to you, cheers again!

Unreal-Dan commented 10 months ago

as per email discussion with deej he was accidentally running the old version, the test version seems to be working well, I will release it

Wietjuh commented 10 months ago

I can confirm that I didn't have issues anymore.