Unreal-Dan
commented
7 months ago I see so you just want to slow down the rt bpm function so that it updates less often? Is that what I'm understanding?
You're saying you'd like it to run once every 15 seconds, and 30 seconds?
Are you comfortable making modifications to the module and rebuilding it yourself? All that is needed is visual studio there's no extra requirements. If you're not comfortable then I can put together some changes for you but it would probably be faster for you to do it.
This function here is responsible for queueing up a bpm update into the logging system:
https://github.com/Unreal-Dan/RekordBoxSongExporter/blob/master/Module/OlvcCallback.cpp#L146
You could add a simple time check inside that function, something like this:
#include <chrono>
// callback for when the bpm changes on a deck
static void bpm_changed(uint32_t deck_idx, uint32_t old_bpm, uint32_t new_bpm)
{
// keep track of 8 last call times, one for each possible deck
static std::chrono::steady_clock::time_point lastCallTime[8];
// adjust period to be some measure of time in milliseconds to ratelimit to
// 1000 / 15 = 15 times per second
const auto period = std::chrono::milliseconds(1000 / 15);
// grab curtime and calculate elapsed since last update on this deck
auto now = std::chrono::steady_clock::now();
auto elapsed = now - lastCallTime[deck_idx];
// if we haven't waited long enough to queue the bpm change, then just discard this change
if (elapsed < period) {
// Discard the call as it is within the rate limit period
return;
}
// otherwise update the last call time and proceed with queuing the bpm change
lastCallTime[deck_idx] = now;
// lookup a player for the deck
djplayer_uiplayer *player = lookup_player(deck_idx);
// make sure the player has a track loaded on it
if (!player || !player->getTrackBrowserID()) {
return;
}
info("BPM change deck %u: %.2f -> %.2f", deck_idx, old_bpm / 100.0, new_bpm / 100.0);
// Push a message to the output file writer indicating the deck changed bpm
push_deck_update(deck_idx, UPDATE_TYPE_BPM);
}I honestly don't know if this will work the way we want, but I'm quite certain it should.
You're going to want to configure the code and rebuild the module how you want, here's a changeset that demonstrates adding this code to the program.
https://github.com/Unreal-Dan/RekordBoxSongExporter/commit/4666d3d70e14d2d1c4fbe514a7db7857df9acab5
Let me know how this goes and if you need any help
Wietjuh
erikrichardlarson
Guili123
Is there a way we could limit the rt bpm function (or in call frequency/time)
I play with timecodes (vinyl) and vinyl flutters.
So, I would love a function that wouldn't update the file x times per second but once a 15/30 seconds (preferably before it sends it over the network to my other PC)
Maybe its an easy config for me locally, maybe more people would like to be able to define it.
Also I only need whole bpm info, not the 0,01 accuracy, but that can be filtered out at my end.
/edit: And I forgot to make it a readable title, please delete if needed 😂