Closed adrienWeiss closed 5 months ago
I fixed the 2nd and 3rd errors - thanks for reporting them.
Less concerned about the test codemod at the moment- I've been working on writing some better tests so that'll go away eventually
I can happily report 0 error when running it (without any plugin) on 1484 files 🎉
we'll do our best to report (& fix) any upcoming issues running vue-upgrade-tool plugins soon
Hi again checking the tool against a large codebase, I found a few issues that you may want to look into :
double setup in test plugin
something looks not right here, looks like the transformer is always adding a
setup
attribute (although it's just thestringLiteralPlugin
test plugin at fault here) https://github.com/UnrefinedBrain/vue-metamorph/blob/6cc36972d83ec53a4dc1e0bbb4ca176875f926ba/src/transform.spec.ts#L169-L172cannot parse empty
script
tagthis is not critical but I think an empty script tag is technically legit
this raises an error
Serialized Error: { code: 'BABEL_PARSER_SYNTAX_ERROR', reasonCode: 'UnterminatedRegExp'
using v-bind in style blocks
For this one I'm not entirely sure,
this raises errors in the tests, but on my codebase it only fails when using
v-bind
in another css function, such asclamp(10px, v-bind(myVar), 100px);
🤔 Anyhow I guess it's more related to postcss than vue-metamorph, but I figured you'd want to know just in caseCheers