Closed cgrand closed 6 years ago
This looks great, thanks for working on this! I'd love to get this in ASAP (and we should cut a release after that).
Testing this I've run into a few speed bumps:
The second line is not indented - I think it should be indented to match the prompt. Maybe like lumo:
cljs.user=> (
#_=> )
This breaks cursor-up and cursor-down in the normal case (single-line editing) - I mean break in the sense that standard readline keys don't work as expected. I'd prefer keymappings that don't break this normal case (single-line) to make room for the special case (multi-line)
Chez's repl handles this very nicely - up works as expected but only shows the top line. Down cycles through each line. This makes the two directions asymmetric, but this only affects multi-line editing.
^R
seems to run the expression - this should be reserved for "reverse-isearch", as per standard readline. Unfortunately good terminal keybindings are a bit difficult to find. How about ^J
, following chez?^C
exception, flurry of autodoc should be fixed once I merge.
except of the indentation in multiline, alles klär
:boom:
Implements multiline edition.
Things to work out: