Closed zhou13 closed 8 years ago
I didn't see the point why we should not try to load the needed modules. Blacklisted or built-in modules will fail to be be modprob, but it will not affect the execution of the program, just generating a warning. Autoloading the required modules is common in such application, like lm_sensor, alsa… On Dec 27, 2015 2:52 AM, "Unrud" notifications@github.com wrote:
The packager (or experienced user) should ensure that all requirements are met, when the program is started. (e.g. the i2c_i801 is blacklisted in some distributions, so remove the blacklist entry). The checks are only an aid for finding the problem if the program is not working. A failed check doesn't necessary mean that the program will not work, it depends on how your system is configured. (e.g. the modules could be compiled into the kernel instead of loaded dynamically).
— Reply to this email directly or view it on GitHub https://github.com/Unrud/init-headphone/pull/4#issuecomment-167400682.
The packager (or experienced user) should ensure that all requirements are met, when the program is started. (e.g. the i2c_i801 is blacklisted in some distributions, so remove the blacklist entry). The checks are only an aid for finding the problem if the program is not working. A failed check doesn't necessary mean that the program will not work, it depends on how your system is configured. (e.g. the modules could be compiled into the kernel instead of loaded dynamically).