Add download output choose option

Unrud / video-downloader

Download videos from websites like YouTube and many others (based on yt-dlp)

GNU General Public License v3.0

795 stars 97 forks source link

Closed ghost closed 2 years ago

ghost commented 2 years ago

Simple changes that will be life-changer to the end-user. Not code complicated and the interface is still clean. This should address #81 and #66 .

Unrud commented 2 years ago

This requires handling edge cases.

The flock syscall is not supported by xdg-document-portal FUSE. We need to investigate other locking mechanisms.
A folder exported into the sandbox might disappear (e.g. unexported or deleted by user). This case must be handled gracefully.
If the app runs in a sandbox and sharing folders is not supported (e.g. older version of xdg-deskop-portal) the button should be hidden?

ghost commented 2 years ago

Thank you for answering this commit. Happy you decided to implement it.

Is there any way we can check if the flock syscall is supported? A check mechanism at the beginning of the script by checking this AND if sharing folders is supported could solve 1. and 3.
2.: I thought it would be automatically handled by the library. Is there any design to this?

Unrud commented 2 years ago

Closing in favor of #152