Unrud / video-downloader

Download videos from websites like YouTube and many others (based on yt-dlp)
GNU General Public License v3.0
751 stars 95 forks source link

Prefer MPEG format? #199

Open vanillajonathan opened 1 year ago

vanillajonathan commented 1 year ago

I find it unclear what exactly the "Prefer MPEG format" switch does. What is "MPEG" format? Is that any MPEG format, or is that H.263, H.264 or H.265, is it MP4? If the toggle is disabled, what format is used instead of "MPEG"?

Why would I want this toggle off? Why would I want this toggle on? What are the advantages and disadvantages? How do I decide?

Maybe it could be rephrased, or have a subtitle, or have a tooltip or something that better explains it?

Unrud commented 1 year ago

What is "MPEG" format? Is that any MPEG format, or is that H.263, H.264 or H.265, is it MP4?

h.264

https://github.com/Unrud/video-downloader/blob/06bad9db6d1ad56ebf405769a652250f9b24aa88/src/downloader/yt_dlp_slave.py#L358

If the toggle is disabled, what format is used instead of "MPEG"?

Best quality

Why would I want this toggle on?

vanillajonathan commented 1 year ago

Maybe the application could inform the user of this?

vanillajonathan commented 1 year ago

Consider adding a tooltip or a popover that explains this.