Unsandboxed / scratch-gui

If it works it works
GNU General Public License v3.0
2 stars 6 forks source link

Deployment doesn't use latest vm branch(?) #51

Closed LilyMakesThings closed 4 months ago

LilyMakesThings commented 4 months ago

Now look, you might think I'm stupid...

David-Orangemoon commented 4 months ago

Whoops

LilyMakesThings commented 4 months ago

Whoops

Crazy because I just tested it locally and it works fine so I must have royally fucked up somewhere in github specifically for that to happen

LilyMakesThings commented 4 months ago

I've got no idea what's going on here, basically the deployment is using an older version of the vm and I cannot get it onto a newer one. Definitely just missing something obvious

LilyMakesThings commented 4 months ago

@GarboMuffin I don't expect you'll have any more of an idea of what's wrong here but I'll tag you anyway. I've used google, I've scrutinised every package and workflow file, I've redeployed, rebuilt, reinstalled every relevant dependency and repo, but scratch-gui is still deploying an old version of the vm.

GarboMuffin commented 4 months ago

The scratch-vm commit hash is defined here:

https://github.com/Unsandboxed/scratch-gui/blob/f9fc28f89abb8fc2249c4a165d05fddb9509b788/package-lock.json#L16470-L16472

76f22f09626e8003a60a4fcff4a409b40057f0b5 is https://github.com/Unsandboxed/scratch-vm/commit/76f22f09626e8003a60a4fcff4a409b40057f0b5

The fix is in scratch-gui do npm update scratch-vm and commit the changes. You can also do npm update which will try to update everything

LilyMakesThings commented 4 months ago

thank you, I had no idea

LilyMakesThings commented 4 months ago

lifesaver 💜

AshimeeAlt commented 4 months ago

yeah