UnseenFaith / komada

Komada: Croatian for `pieces`, is a modular bot system including reloading modules and easy to use custom commands.
MIT License
62 stars 31 forks source link

BUG: SettingGateway#updateArray() is not type-agnostic #345

Closed mcumbers closed 7 years ago

mcumbers commented 7 years ago

Version of Komada

0.20.8

Are core files modified?

No

Describe the problem

It's not possible to use the updateArray function with SettingGateway instances initialized with a type other than guild

Expected Behaviour

updateArray should update arrays in SettingGateway instances based on all types

Actual Behaviour

updateArray throws an error and fails to update arrays on SettingGateway instances other than ones based on guild types

Steps to Reproduce.

kyranet commented 7 years ago

Found the issue. Unlike SettingGateway#update, SettingGateway#updateArray does not have a parameter reserved for guild resolving.

UnseenFaith commented 7 years ago

Should be fixed in #335 @mcumbers

Let me know if it's not.