Update log colors - Githubissues

UnseenFaith / komada

Komada: Croatian for `pieces`, is a modular bot system including reloading modules and easy to use custom commands.

MIT License

62 stars 31 forks source link

Update log colors #355

Closed HellPie closed 7 years ago

HellPie commented 7 years ago

Proposed Semver Increment Bump: PATCH (None?)

Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)

Added wtf and verbose log types (wtf = What a Terrible Failure according to Android's Log class).
Added shortcut event for verbose log type.
Every log level except for error, warn and wtf only colors the text, not the background, to better show warns and errors.
Level verbose is colored grey (chalk dim does not work in most Windows environments) to not spam too many colors for those who will need to read the logs
Level wtf is marked as underlined and bold, and highlights the entire message to be instantly recognizable due to the fact it should only be used for extreme case scenarios and "Terrible Failures".
Log formatting is now managed through formats in log.js

(If Applicable) What Issue does it fix?

Fixes... Nothing. The logs are more chill if there are no issues.

References

Klasa original pr (with screenshot): dirigeants/klasa#19

HellPie commented 7 years ago

sorry about the extra commits, gitkraken pulled them when syncing the repo and I didn't notice.

CyberiumShadow commented 7 years ago

dw about the extra commits.

It's just me being an idiot and rewriting public history

CyberiumShadow commented 7 years ago

If this is complete, I will merge this and add a note for Faith to revisit it

HellPie commented 7 years ago

I don't like it either. With klasa it's easier cuz I just disable chalk altogether, but here unless I re-initialize clk on every run(...) there isn't really another way and afaik an if(!var) is still faster than a new var assignment

UnseenFaith commented 7 years ago

Yeah it's fine. This logging system is pretty old and due for an update.

HellPie commented 7 years ago

Btw this allows to potentially let the user specify their own format object, main reason I moved from the switch block to that. My plan was to use it so that IPC could send the bot the preferred logging config, but this also opens it up for more customization for everyone.

CyberiumShadow commented 7 years ago

Ah... Codacy is complaining about nested ternaries

kyranet commented 7 years ago

I agree with Faith, we could remove chalk as a dependency and make it by ourselves using the special characters used for this task. As we are only using this in a single file.

CyberiumShadow commented 7 years ago

@UnseenFaith @kyranet If you guys agree, I will merge this as an interim feature.

kyranet commented 7 years ago

The nested ternary confuses me a bit to be honest, it's a bit hard to read.

CyberiumShadow commented 7 years ago

good enough imo