refactor(cli): Refactor RPC server and fix tests

UnstoppableSwap / core

Bitcoin–Monero Cross-chain Atomic Swap (+ GUI)

GNU General Public License v3.0

18 stars 6 forks source link

Closed binarybaron closed 2 months ago

binarybaron commented 2 months ago

Use the Request trait introduced in https://github.com/UnstoppableSwap/xmr-btc-swap/pull/10 for the RPC server
Delegate deserialization of RPC server method parameters to serde by using structs like BuyXmrArgs
Remove get_raw_states RPC server method because it's not used
Fix RPC server tests including removing test for the "log reference id" feature which was removed as part of https://github.com/UnstoppableSwap/xmr-btc-swap/pull/10
Rename GetCurrentSwap struct to GetCurrentSwapArgs

Einliterflasche commented 2 months ago

looks very solid so far. at least one test failing (with the regex error) can be fixed by bumping tracing subscriber to 0.3 in monero-harness