search

Unstructured-IO / unstructured-api-tools

Apache License 2.0
28 stars 10 forks source link

chore: start adding missing end to end tests #138

Closed cragwolfe closed 1 year ago

cragwolfe commented 1 year ago

✅ Sets the pattern for the comprehensive unittests in https://github.com/Unstructured-IO/unstructured-api-tools/issues/104 .

:white_check_mark: Adds a pipeline test project with a root directory of test_unstructured_api_tools/pipeline-test-project/

:white_check_mark: Generates web API's test_unstructured_api_tools/pipeline-test-project/prepline_test_project/api/ from notebooks under test_unstructured_api_tools/pipeline-test-project/pipeline-notebook with make generate-test-api

:white_check_mark: Ensures the generated API's match expected in CI with make api-check-test

✅ Adds FastAPI client tests against the generated API's in test_unstructured_api_tools/api/test_file_apis.py

There are still many notebooks to add under test_unstructured_api_tools/pipeline-test-project/pipeline-notebook and many more permutations to test per https://github.com/Unstructured-IO/unstructured-api-tools/issues/104 , but this is establishing the pattern.

MthwRobinson commented 1 year ago

@stamzid - Can you pick up review on this one?

cragwolfe commented 1 year ago

CC @amanda103

amanda103 commented 1 year ago

Okay these tests look good for a baseline happy path! I can see the new tests are passing in the GHA check, but maybe we can pair on running these new tests locally and I can smash the approval button @cragwolfe ?

cragwolfe commented 1 year ago

Okay these tests look good for a baseline happy path! I can see the new tests are passing in the GHA check, but maybe we can pair on running these new tests locally and I can smash the approval button @cragwolfe ?

Sounds good, let's do that on Monday!