search

Unvanquished / updater

QML based updater to install, update and launch the Unvanquished game.
https://unvanquished.net/download
15 stars 7 forks source link

Make cmake build libaria2. #29

Closed Viech closed 3 years ago

Viech commented 9 years ago

Also it should print a human readable warning when the git submodule isn't initialized or maybe even perform the initialization.

DolceTriade commented 9 years ago

This would be basically redoing libaria's build system and that's no fun because libaria has a ton of options. I'll leave it open, but I really don't have any intention of doing it. The submodule part though sounds like a good idea.

Viech commented 9 years ago

I'm talking about moving the commands from the readme into cmake, not redoing libaria2's build system.

DolceTriade commented 9 years ago

Ah, I didn't think of that. Clever.

slipher commented 3 years ago

Now that we are using Qt which is difficult to install, we want to be able to use the Docker build during development. Since aria takes longer to build than our code, and rarely changes, it is desirable to build in a separate Docker layer earlier than the one in which our code is built. This is probably impossible if we integrate the commands into the qmake (what we are using now instead of cmake) build system. Hence, shelling out from the main build system to build aria is now undesirable.