search

Unvanquished / updater

QML based updater to install, update and launch the Unvanquished game.
https://unvanquished.net/download
15 stars 7 forks source link

Add license #56

Closed slipher closed 5 months ago

slipher commented 3 years ago

By statically linking Qt we are "infected" with the GPL, so that would be a logical choice I guess.

There are 2 contributors outside of the core Unvanquished dev team:

$ git shortlog -sne
    64  dolcetriade <vcelestialragev@gmail.com>
    21  DolceTriade <vcelestialragev@gmail.com>
    20  Thomas Debesse <dev@illwieckz.net>
    20  slipher <dog964@xemaps.com>
     4  Roman Chistokhodov <freeslave93@gmail.com>
     2  Ryozuki <clud6565@gmail.com>
     1  Thomas Debesse <github@illwieckz.net>
DolceTriade commented 3 years ago

Did they make any lasting changes? Perhaps we can remove them?

slipher commented 3 years ago

We could also consider the MIT license, since I am adding a piece of MIT-licensed code in #58. It is GPL-compatible.

We can at least try to contact them. @FreeSlave @edg-l May we license the code under GPL and/or MIT licenses?

illwieckz commented 3 years ago

For FreeSlave, most commits are about the readme and docker files, those commits do not contribute to the binary itself and can't be tainted by GPL, one commit changes the compiled/executed code though, but it would be hard to call this one original. In this commit one change is about embedding an icon in windows binary the expected way to do it, the other change is making a link clickable and display a hand pointer when hovering the link. On the copyright side this looks to be very basic and done “the way to do it” (it would be like doing onClick() in javascript and hover CSS class), and on the patent side, idea of displaying a hand hovering a link and opening an url by clicking on a link is not original at all.

For edg-l, commits are about adding some qml properties in a way it can't be original, and some standard values (1280×720 resolution can't be copyrighted…).

It would be cool to get a waving hand from our friends because it's always nice to do so, would be cool to credit them for making the updater and Unvanquished better, but I would assume nothing is preventing us to produce a build that would taint updater with GPL, at least on this side.

edg-l commented 3 years ago

Ryozuki clud6565@gmail.com

This my old name and old mail, sorry for the inconvenience.

As for me, you can license it under GPL or MIT as you like.

FreeSlave commented 3 years ago

Hello, I'm fine with that change.

ghost commented 2 years ago

This is likely fixed, then?