search

Unvanquished / updater

QML based updater to install, update and launch the Unvanquished game.
https://unvanquished.net/download
16 stars 7 forks source link

Fixes #60

Closed slipher closed 3 years ago

slipher commented 3 years ago

The most interesting one is "Asynchronously request latest versions". This uses the splash screen timer as a timeout for the versions request. So the splash screen will never be displayed more than 3 seconds unless an updater update is being attempted. This should fix the worst of #35.

DolceTriade commented 3 years ago

Looks good. If you remove the upload speed stuff, please also make sure we disable uploading in Aria2. Maybe there is a flag?

slipher commented 3 years ago

The motivation for upload speed is since this is using bittorrent, as you download, you can also upload to other peers, hence we display that speed.

Thanks for explaining that, I'll remove the commit.

In my Linux VM, the version check is consistently taking 9 seconds. So maybe the 3-second timeout is too short, and the version check should get a longer timeout than the timeout for the splash screen. Also I'll try doing the version fetch with aria instead of qt and see if that makes it faster.

slipher commented 3 years ago

I found that changing the versions URL from http to https makes the request finish in <1 second, instead of 9 seconds. A similar effect also occurs on Mac (but not Windows). So I guess I'll merge now, even though this doesn't exactly inspire confidence...