Closed illwieckz closed 1 year ago
I noticed we already had a ENGINE_BINARIES
list so I reused it.
I added a list comprehension for the windows binary list.
I don't mind this one being “computed”, the purpose of the PR is that the proposed design allows anyone to hardcode the list in an obvious and easy way, something the proposed code doesn't prevent. The code also not assumes all platforms have the same amount of things done the same way (unlike my original proposition in #6).
LGTM
This is an alternate way to deduplicate things (see #6) that is still done the hardcoded way, one can for example do this without adding or editing any logic to the code: