search

UnwilledTangent / pe

0 stars 0 forks source link

Unique Identifier ought to be NRIC only, not name :) #1

Open UnwilledTangent opened 1 year ago

UnwilledTangent commented 1 year ago

image.png

As you can see from the image (entry 7 and command input field), it would appear that CareFlow checks whether a patient is unique/already exists by comparing via name, not NRIC. You must be careful with this, because 2 people could have the same name in Singapore. Recommended to just change the unique identifier to NRIC, which is guaranteed to be unique! :)

p.s. Upon further testing, it would appear that you did compare via NRIC. That is great!

nus-se-script commented 1 year ago

Team's Response

Rejected because this issue matches one of the enhancement listed in the 'Appendix: Planned Enhancements' of the DG.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]