nus-se-bot
commented
1 year ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Invalid birthday is not explicitly handled
When keying in an invalid birthday, it did not specifically handle for the possibility of a user keying in a date that is invalid, such as 29th Feb on a non-leap year. The user may be led to believe that this date is indeed between the range specified (01/01/1990 to current date) yet there is no indication that this date inputted is an invalid one because the current error message is that "Date of birth should only contain numeric characters" which is not exactly the error here.
[original: nus-cs2103-AY2223S2/pe-interim#64] [original labels: severity.Low type.FunctionalityBug]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Thanks for pointing this out.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
Great job detecting that 30 Feb is not a valid date! However, I think it would have been better if the error message reflects the actual error. You could append the error message "Please enter valid date. 30-02-2023 is not a valid date". Because it helps the user see what is the problem faster.