nus-pe-bot
commented
1 year ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Poor Phone Number validation rules
While it is stated that a phone number may be a string of numbers, but invalid numbers such as 00000000 can be saved, which in the context of a GP clinic is not useful
[original: nus-cs2103-AY2223S2/pe-interim#3022] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
We acknowledge that the phone number validation can be improved, as indicated in one of the planned enhancements listed in the 'Appendix' of the Developer Guide.
We understand that the tester may have concerns about the current approach, as it allows users to input non-valid phone numbers. However, our goal is to provide users with more flexibility when entering phone numbers.
In the current phase, we have prioritized flexibility over strict validation for the phone field. While there may be room for improvement, we believe that this approach provides users with more options for entering their phone numbers.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.VeryLow`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
Error checking should be done to make sure that reserved phone numbers should not be added to the emergency contact number field, like "995".