search

UoA-eResearch / research-hub-web

Research Hub Web
https://research-hub.cer.auckland.ac.nz
MIT License
3 stars 2 forks source link

Created new directive to tidy search results with external hrefs #19

Closed Hganavak closed 5 years ago

Hganavak commented 5 years ago

Created new @Directive appSearchResultLink. This sets several attributes of a search result link based on the content type. Works in both list and card views. Requires @Input binding item of type ListItem.

<a appSearchResultLink [item]="item">

Was originally designed to fix a bug where external hrefs didn't work in the card view. Has now also been applied to the list view in order to tidy and reduce existing code.

Hganavak commented 5 years ago

This bug fix is now outdated and incompatible with the current version of master.

It is easier to create a new fix from scratch rather than attempting to deal with the merge conflicts/refactoring involved in using this branch.

For the new branch see: updated-cardview-external-hrefs