search

UoA-eResearch / research-hub-web

Research Hub Web
https://research-hub.cer.auckland.ac.nz
MIT License
3 stars 2 forks source link

Updated cardview external hrefs #23

Closed Hganavak closed 5 years ago

Hganavak commented 5 years ago

Created a new directive appSearchResultLink to automate the process of determining whether an item should be an internal or external link, and whether it should use the analyticsService trackPolicy() function.

As this is the first Angular directive used in the project, I also created new folder directives/ on the same level as our components/, services/, pipes/ etc.

Hganavak commented 5 years ago

Fixed all existing unit tests so that they no longer error. Will need to be refactored in future as they currently only test if the component/service was created successfully.

Writing the first proper unit test now.