UoA-eResearch / research-hub-web

Research Hub Web
https://research-hub.cer.auckland.ac.nz
MIT License
3 stars 2 forks source link

drive short name needs restricting to 50 or fewer characters. #56

Open akea013 opened 3 years ago

akea013 commented 3 years ago

please restrict length of name users can supply for drive short name to no more than 50 characters. Supplying shortname NZ-perioperative-department-responses-to-Covid-19 which gets prefixed by resmed202000038- gives error

Name is too long. Please reduce to a maximun of 60 characters. (Workflow:UoA-Unifiles-Validator / Scripting (item4)#7)

Hganavak commented 3 years ago

What drive names are you referring to? Do you just mean the storage folder name in the Request Research Storage form?

Screen Shot 2020-10-07 at 9 25 09 AM

akea013 commented 3 years ago

See screenshot of vra error message attached.

Submitted name was

"short_name": "NZ-perioperative-department-responses-to-Covid-19

which was prefaced by vra with the string resmed202000038-

so the string that they are complaining about is

resmed202000038-NZ-perioperative-department-responses-to-Covid-19

needing to be shortened to 60 chars - it's 66.

And the "resmed202000038-" is 16 characters,

So the submitted short name on the form (where you have selected, yes) needs to be restricted to 50 characters.

Thanks Sam.

--

Anita


From: Sam Kavanagh notifications@github.com Sent: Wednesday, 7 October 2020 9:27 a.m. To: UoA-eResearch/research-hub-web Cc: Anita Kean; Author Subject: Re: [UoA-eResearch/research-hub-web] drive short name needs restricting to 50 or fewer characters. (#56)

What drive names are you referring to? Do you just mean the storage folder name in the Request Research Storage form?

[Screen Shot 2020-10-07 at 9 25 09 AM]https://user-images.githubusercontent.com/2230752/95256317-2506bf00-087f-11eb-8b89-6079fa358b3e.png

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/UoA-eResearch/research-hub-web/issues/56#issuecomment-704533886, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIIG64IYBTBSLZD466PKYZLSJN4TJANCNFSM4SFNPQVA.

akea013 commented 3 years ago

this is for ticket REQ1240531:

General

Researcher: Name: Jennifer Long Username: jlon559 Email: Jennifer.long@auckland.ac.nz Request type: New

Project

Title: What have we learnt from Covid-19 at the frontline of healthcare? A Abstract: The Covid-19 pandemic has had an unprecedented effect on frontline hospital staff. From a 'standing start' each hospital has dealt with the uncertainty and fear to create new ways of working. Priorities were to limit spread of the disease, care for patients, and ensure the well-being of staff. In a qualitative interview study, we propose capturing the experiences of perioperative staff from NZ hospitals to explore how they responded, what worked, what didn't, and lessons learnt. Our aim is to draw on this unique experience to inform a perioperative pandemic response in the workplace, addressing disease containment, patient care, and staff well-being. Storage options: Dropbox, Network Research Storage End date: 2021-12-17 Fields of research: 11 Medical and Health Sciences

Data Info

Short name: NZ perioperative department responses to Covid-19 Data needs: Part of a funded project research Requires human ethics research Need for external collaborator access Project members: Jennifer Long, Jennifer.long@auckland.ac.nz, , Full Access, Data Contact Jennifer Weller, j.weller@auckland.ac.nz, , Full Access, Project Owner Data Owner Mataroria Lyndon, mataroria.lyndon@auckland.ac.nz, , Full Access,

Data Size

This year: 7 Gigabytes Next year: 7 Gigabytes Comments:


From: Sam Kavanagh notifications@github.com Sent: Wednesday, 7 October 2020 9:27 a.m. To: UoA-eResearch/research-hub-web Cc: Anita Kean; Author Subject: Re: [UoA-eResearch/research-hub-web] drive short name needs restricting to 50 or fewer characters. (#56)

What drive names are you referring to? Do you just mean the storage folder name in the Request Research Storage form?

[Screen Shot 2020-10-07 at 9 25 09 AM]https://user-images.githubusercontent.com/2230752/95256317-2506bf00-087f-11eb-8b89-6079fa358b3e.png

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/UoA-eResearch/research-hub-web/issues/56#issuecomment-704533886, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIIG64IYBTBSLZD466PKYZLSJN4TJANCNFSM4SFNPQVA.

Hganavak commented 3 years ago

Just to confirm. The only update you would like us to make on our end, is to make the input form (in the screenshot above):

Please provide a descriptive title for your storage folder (e.g. GDC-data)?

To allow a max of 50 chars?

If so we can add that on to the beginning of our next sprint (so it'll be deployed on the 19/20th). Does that work for you?

akea013 commented 3 years ago

Yes that's correct.

But one more thing: I had a dropbox storage request last week that submitted the short name

"Project Data" which is hardly unique.

That's ok for research-drive requests as it will be prefixed by the group base name making it unique,

but for dropbox requests, as was that case, we need to request allocations for unique folder names.

Please modify the statement

"Please provide a descriptive title for your storage folder (e.g. GDC-data)?"

to something like

"Please provide a unique descriptive title for your storage folder (e.g. GDC-data-)"

(maybe you want to ask Yvette for input on this)

and notice that I've removed the question mark as this statement is not a question but a request.

We already have a dropbox folder named "Marsden-Data" - what's to stop another dropbox request using the same string? Let alone "Project Data". Nothing in your current instructions.

--

Anita


From: Sam Kavanagh notifications@github.com Sent: Wednesday, 7 October 2020 11:20 a.m. To: UoA-eResearch/research-hub-web Cc: Anita Kean; Author Subject: Re: [UoA-eResearch/research-hub-web] drive short name needs restricting to 50 or fewer characters. (#56)

Just to confirm. The only update you would like us to make on our end, is to make the input form (in the screenshot above):

Please provide a descriptive title for your storage folder (e.g. GDC-data)?

To allow a max of 50 chars?

If so we can add that on to the beginning of our next sprint (so it'll be deployed on the 19/20th). Does that work for you?

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/UoA-eResearch/research-hub-web/issues/56#issuecomment-704583651, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIIG64KUJDNPPJXMQZIICEDSJOJ35ANCNFSM4SFNPQVA.

Hganavak commented 3 years ago

"Please provide a unique descriptive title for your storage folder (e.g. GDC-data-)"

We can't reasonably expect users to generate a unique string here just for our internal purposes, that would be super duper weird interface.

Could I suggest updating your Dropbox creation API/tool to just append 5 random alphanumeric characters to the folder name? We could then limit the short-name to 45 characters on our end.

Alternatively, we could do this for you, but we currently don't have any way of knowing whether the user is requesting only a Dropbox folder, or Dropbox + Research Storage, so we would end up also appending the 5 random characters to Research Storage short names (which as you mentioned don't need this).

and notice that I've removed the question mark as this statement is not a question but a request.

I noticed this too, we will fix that ASAP?

akea013 commented 3 years ago

This is exactly what you need to speak to Yvette about.

This naming system is hers, but when people read your instructions they reply (based on your current wording) with dropbox folder names like "Project Data".

You and Yvette need to work out how we can avoid the extra steps involved in us gong back to requesters asking them to change the name they have provided when they have followed your instructions.

--

Anita


From: Sam Kavanagh notifications@github.com Sent: Wednesday, 7 October 2020 12:10 p.m. To: UoA-eResearch/research-hub-web Cc: Anita Kean; Author Subject: Re: [UoA-eResearch/research-hub-web] drive short name needs restricting to 50 or fewer characters. (#56)

"Please provide a unique descriptive title for your storage folder (e.g. GDC-data-)"

We can't reasonably expect users to generate a unique string here just for our internal purposes, that would be super duper weird interface.

Could I suggest updating your Dropbox creation API/tool to just append 5 random alphanumeric characters to the folder name? We could then limit the short-name to 45 characters on our end.

Alternatively, we could do this for you, but we currently don't have any way of knowing whether the user is requesting only a Dropbox folder, or Dropbox + Research Storage, so we would end up also appending the 5 random characters to Research Storage short names (which as you mentioned don't need this).

and notice that I've removed the question mark as this statement is not a question but a request.

I noticed this too, we will fix that ASAP?

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/UoA-eResearch/research-hub-web/issues/56#issuecomment-704600213, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIIG64IUGE5DJXHOWFZMIP3SJOPVZANCNFSM4SFNPQVA.

akea013 commented 3 years ago

Sam

I had a talk with Martin about dropbox folder naming today, and he explained that it probably doesn't matter that folder names are not unique - as dropbox uses an id rather than the name in any processing.

Users access their folder via groups (and hence ids).

I used to be able to view dropbox folders on their admin console (could search by folder name) but can only see groups now - so it seems like there won't be an issue with multiple folders with the same name.

So please may I retract the second request I made that instructions request a unique

label for dropbox name. My misunderstanding.

Apologies.

--

Anita


From: Sam Kavanagh notifications@github.com Sent: Wednesday, 7 October 2020 12:10 p.m. To: UoA-eResearch/research-hub-web Cc: Anita Kean; Author Subject: Re: [UoA-eResearch/research-hub-web] drive short name needs restricting to 50 or fewer characters. (#56)

"Please provide a unique descriptive title for your storage folder (e.g. GDC-data-)"

We can't reasonably expect users to generate a unique string here just for our internal purposes, that would be super duper weird interface.

Could I suggest updating your Dropbox creation API/tool to just append 5 random alphanumeric characters to the folder name? We could then limit the short-name to 45 characters on our end.

Alternatively, we could do this for you, but we currently don't have any way of knowing whether the user is requesting only a Dropbox folder, or Dropbox + Research Storage, so we would end up also appending the 5 random characters to Research Storage short names (which as you mentioned don't need this).

and notice that I've removed the question mark as this statement is not a question but a request.

I noticed this too, we will fix that ASAP?

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/UoA-eResearch/research-hub-web/issues/56#issuecomment-704600213, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIIG64IUGE5DJXHOWFZMIP3SJOPVZANCNFSM4SFNPQVA.