UoB-HPC / SimEng

The University of Bristol HPC Simulation Engine
https://uob-hpc.github.io/SimEng
Apache License 2.0
93 stars 20 forks source link

Uncaught config option errors #391

Closed jj16791 closed 8 months ago

jj16791 commented 8 months ago

In ModelConfig::setExpectations, a number of config options are queried before ModelConfig::validate is run. If those config options are errored in some way (e.g. missing), the errored access has not been flagged by the validation step and thus the SimEng is liable to crash. Some options do pre-validate the access in ModelConfig::setExpectations but access the config option before the result of the =re-validation is checked.

The config options at fault include: