UoB-HPC / SimEng

The University of Bristol HPC Simulation Engine
https://uob-hpc.github.io/SimEng
Apache License 2.0
93 stars 20 forks source link

Boolean Config Parameter Output #398

Open dANW34V3R opened 9 months ago

dANW34V3R commented 9 months ago

Currently, if you incorrectly type "True" or "False" for any of the config options the resulting error is simply:

/.../SimEng/src/include/simeng/config/yaml/ryml.hh:20693:could not deserialize value

Process finished with exit code 134 (interrupted by signal 6:SIGABRT)

This doesn't give enough information to decern what or where the issue is. Ideally we would have a print out similar to:

[SimEng:ModelConfig] Invalid ISA value of "rv64asdf" passed in config file due to "rv64asdf not in set {AArch64, rv64}" error. Cannot continue with config validation. Exiting.

There may not be a simple solution to this. Options include first comparing as a string before converting or erroring. It may be possible to catch the error from RYAML and then giving a more more informative print out.