search

UoB-HPC / stdpar-nbody

https://research-information.bris.ac.uk/en/publications/efficient-tree-based-parallel-algorithms-for-n-body-simulations-u
MIT License
2 stars 0 forks source link

Use iota_view instead of vector of indices #1

Closed gonzalobg closed 5 months ago

limefax commented 5 months ago

On my setup this makes the GCC version run in serial. I believe this is to be changed with P2408R5 which currently does not have support (https://en.cppreference.com/w/cpp/compiler_support/23).

Are you aware of a way to make this work for GCC?

gonzalobg commented 5 months ago

I'm using a container that has this line in it: 

sed -i 's@std::is_same<typename std::iterator_traits<_IteratorType>::iterator_category, std::random_access_iterator_tag>@std::integral_constant<bool, std::random_access_itera\
tor<_IteratorType>>@g' /usr/include/c++/${gcc_ver}/pstl/execution_impl.h

where ${gcc_ver} is 13 in that container. There is a GCC bug and patch open to fix this, but I believe they are working on a slightly different patch and don't know the status of it (will ask, not sure if its worth trying with gcc trunk).

limefax commented 5 months ago

Nice patch, I have added this to another PR and have merged it in.