search

UoaWDCC / ASPA-EnrollmentForm

6 stars 1 forks source link

[ASPA-027] Made the to-be-disabled buttons look and behave like they are disabled #29

Closed AnubhavKhanna07 closed 4 years ago

AnubhavKhanna07 commented 4 years ago

Issue: The look and behaviour of the to-be-disabled buttons needed to be changed. A javadoc comment had the wrong parameter.

Solution: A class 'btn-disabled' was added to the classList of the respective buttons. 'btn-disabled' was defined in the aspa.webflow.css file. This stopped the buttons from growing in size when they are hovered over. Also the opacity of the buttons was reduced. The buttons were made visually unclickable. The wrong parameter in the javadoc comment was corrected.

Risk: None expected

Reviewed by: Raymond Feng, Martin James Tiango, Lucas Gao

Ray-F commented 4 years ago

See my edit to your PR description (just readability improvements).

AnubhavKhanna07 commented 4 years ago

See my edit to your PR description (just readability improvements).

Cool, that's much better. Cheers!