UoaWDCC / ASPA-EnrollmentForm

6 stars 1 forks source link

[ASPA-020] Integrated ASPA-020 changes with multi-event manager (ASPA-024) #31

Closed Ray-F closed 4 years ago

Ray-F commented 4 years ago

Issue: Highlighting in Gsheet_Model_Interface was broken due to new event sheets being used and available after the implementation of 020, specifically on how highlighting a row on a specific sheet requires a sheetId but we only have variable sheetName defined in model class.

Solution: Made a new function get_sheet_id($sheetName) that converts sheetName to sheetId, and uses this to determine which sheet should be highlighted on.

Risk: n/a

Reviewed by: Martin, Lucas, Anubhav

Other notes: Recommended to review changes through 'commit' view instead of 'files changed' view. This allows for a better understanding of work history, and provides context with references in title/summary blocks per commit.

Ray-F commented 4 years ago

Good stuff! the commit messages are soooo damn clean. It's so nice reading pull requests commit by commit. Good job Raymond! 😃

Much love ❤️!