search

UoaWDCC / ASPA-EnrollmentForm

6 stars 1 forks source link

[ASPA-034] Made the ok button functioning when the information on page 3 remains unchanged #39

Closed AnubhavKhanna07 closed 4 years ago

AnubhavKhanna07 commented 4 years ago

Issue: The okay button was not working when the user navigates from page 3 to page 4 and then navigates back to page 3, when the data in the name and email fields has not changed. Also the enter key was still allowing repeated requests.

Solution: The ok button was disabled so the user cannot make repeated requests while on the page. The ok button only gets reenabled when the user navigates to a different page or when an error is identified on the same page. Also, the previous implementation of preventing repeated requests was removed. The check was inserted in the key bindings code section which checks to see if the ok button on page 3 is disabled before making the enter key have its effect.

Risk: Nothing

Reviewed by: Raymond Feng, Lucas Gao

AnubhavKhanna07 commented 4 years ago

Looks good! Made a quick change to code block alignment on line 222 (setTimeout() statement) to enhance readability – purely cosmetic.

Cool, thanks man!