UoaWDCC / uasc-web

Project with the University of Auckland Snowsports Club Website & Booking System. Established in 2023.
https://uasc.co.nz
6 stars 2 forks source link

Make workflow fail for frontend if there are TS errors #377

Closed bcho892 closed 5 months ago

bcho892 commented 5 months ago

Right now the frontend still passes builds even if there are type errors, allowing broken code to make it into master.

This runs tsc before builds so type errors are caught.

Also fixed the existing errors

bcho892 commented 5 months ago

yea... image

github-actions[bot] commented 5 months ago

Visit the preview URL for this PR (updated for commit 041868a):

https://uasc-ceebc--pr377-331-frontend-add-ts-rlty3a5q.web.app

(expires Fri, 31 May 2024 11:23:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa