UoaWDCC / uasc-web

Project with the University of Auckland Snowsports Club Website & Booking System. Established in 2023.
https://uasc.co.nz
6 stars 2 forks source link

Convert ALL dates sent to the backend to UTC #466

Closed bcho892 closed 4 months ago

bcho892 commented 4 months ago

After some "stress" testing of the site, it was found that there were super jank bugs relating to the dates. These were things such as:

Which led to the work in #463 #421 #465

Instead to combat this it was decided to stop using Date where possible on the back end, and make sure that all "dates" are "normalised" to the UTC 00:00:00 before being sent to the backend.

Big change that was verified to not break anything was to get rid of the DatesToDateRange function on the backend, in favour of a Timestamp alternative.

No functionality was broken, however some tests needed to be re-written to accomodate for the new changes - hopefully the current coverage is enough

Would close #431 `

Have also updated the wiki with https://github.com/UoaWDCC/uasc-web/wiki/Backend-Architecture#note-on-dates and https://github.com/UoaWDCC/uasc-web/wiki/Frontend-Architecture#dateutils

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit c72ca21):

https://uasc-ceebc--pr466-449-frontend-convert-l31zd3fw.web.app

(expires Sun, 30 Jun 2024 09:17:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa