607 create an endpoint to demote non admin users

UoaWDCC / uasc-web

Project with the University of Auckland Snowsports Club Website & Booking System. Established in 2023.

https://uasc.co.nz

6 stars 2 forks source link

607 create an endpoint to demote non admin users #643

Closed jeffplays2005 closed 3 months ago

jeffplays2005 commented 3 months ago

Created endpoint in AdminController Created new method in AuthService and its corresponding test, this method fetches all users(1000+)

Created endpoint tests, the endpoint isn't tested on 1000+ members as the fetch users method is confirmed to be working with 1000+ in the tests for AuthService.

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit 0a76739):

https://uasc-ceebc--pr643-607-demote-non-admin-5dotszke.web.app

_{(expires Fri, 26 Jul 2024 02:49:25 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa}

jeffplays2005 commented 3 months ago

Will be removing the test for 1000+ users as this is somewhat redundant after testing locally and takes too long.

bcho892 commented 3 months ago

Will be removing the test for 1000+ users as this is somewhat redundant after testing locally and takes too long.

yea very bad idea to do this, what you could do is see if you can set a limit on the pagination and then make it configurable