added message when user logged into their account

zlrkw11 commented 2 months ago

github-actions[bot] commented 2 months ago

Visit the preview URL for this PR (updated for commit 9368012):

https://uasc-ceebc--pr766-555-add-feedback-for-vz2238gf.web.app

_{(expires Tue, 03 Sep 2024 03:55:33 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa}

zlrkw11 commented 2 months ago

Easy, I wanted to make a component but thought alert was needed

On Mon, Aug 26, 2024, 4:24 PM Benson Cho @.***> wrote:

@.**** commented on this pull request.

The PR says

In client/src/components/composite/LoginForm/LoginForm.tsx https://github.com/UoaWDCC/uasc-web/pull/766#discussion_r1730643781:

@@ -57,6 +57,7 @@ const LoginForm = ({ if (isLoading || !loginHandler) return try { setIsLoading(true)

alert("Logging In...")

we want something to display under the button, not an alert (which blocks everyting)

— Reply to this email directly, view it on GitHub https://github.com/UoaWDCC/uasc-web/pull/766#pullrequestreview-2259699032, or unsubscribe https://github.com/notifications/unsubscribe-auth/APNZZPJEZHIYAKH2SHG2LTLZTKUXRAVCNFSM6AAAAABNDGJGCCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJZGY4TSMBTGI . You are receiving this because you authored the thread.Message ID: @.***>

zlrkw11 commented 2 months ago

https://github.com/user-attachments/assets/1794f6c8-6661-4b92-bcc5-324bceecebcb

zlrkw11 commented 2 months ago

https://github.com/user-attachments/assets/7b7e6d19-a4e6-4789-a22a-62d171360ecd

updated

UoaWDCC / uasc-web

added message when user logged into their account #766

The PR says