#3: [Home] hero - Githubissues

UoaWDCC / wdcc-website-v3

2024 Website Refresh

0 stars 0 forks source link

#3: [Home] hero #39

Closed raymondyangdev closed 3 months ago

raymondyangdev commented 3 months ago

Context

The hero section is a crucial part of the homepage, designed to grab the users attention and encourage them to explore more about WDCC. This update implements an engaging call-to-action on the landing page

Closes #3: [Home] hero

What Changed?

Added a new Hero section to the homepage.
Incorporated an call-to-action button with a join link.

How To Review

web/src/components/home/Hero.tsx
web/src/pages/index.astro

Testing

Manually tested the Hero section appearance and responsiveness across screen sizes.
Verified the call-to-action button's link redirects to Google form.
No significant risks identified, changes are confined to the homepage.

Notes

Nil

raymondyangdev commented 3 months ago

@Oculux314

Thanks Nate for picking those up. I only tested as small as my browser could get 😆 but I've fixed it tested it at different sizes using the Dev Tools.

I agree that the Pill Button and Responsive Image should have their own components due to their customised styling and functionality.

However, I don't think the Join for 2024 button needs its own component. Since it's just a straightforward implementation using a Shadcn Button, we can use the Button component directly without nesting it in a separate component.

Also, I completely missed the point of Strapi and now have integrated the Hero section with it.

raymondyangdev commented 3 months ago

After some more thought, SkybluePillButton also seems redundant, given that we only need to specify rounded-full to className to turn it into a Pill Button and the skyblue variant has been added to web/src/components/ui/button.tsx.

I have removed it for now. Let me know you think and whether you think it deserves it's own component @Oculux314 @Bobsters6666