search

UoaWDCC / wdcc-website-v3

2024 Website Refresh
0 stars 0 forks source link

01 navbar #41

Open TrissyG opened 4 months ago

TrissyG commented 4 months ago

Context

Implements a navbar to be rendered on all pages of the website.

Closes #4

What Changed?

We did the following...

How To Review

Testing

UI Testable when testing framework implemented.

Notes

raymondyangdev commented 4 months ago

Looks good! 🔥

Few questions from me:

  1. Is there a reason why we're not highlighting that we're on the home page/root on the desktop menu? web/src/components/navigation/Header.tsx Line 88: && item.route !== "/"
  2. Are we planning on integrating Strapi for our NavItems? I think we discussed this in our stand up(?) - happy to work on this if we are.
TrissyG commented 4 months ago

RE: @raymondyangdev

1) I was in favour of not having 'Home' highlighted as I think it looks a bit strange to have a non-user-navigated 'selection' being shown. I also think that given our mostly techie/young target audience we could omit it entirely and just have the logo be the home link. Nielsen research tells me I'm wrong, so i will make a commit rn to add the home highlight lol

2.) Yes, I have not done that, if its an easy fix then it would be great if you could implement that on a single commit and i can steal the process for the footer branch :33

raymondyangdev commented 4 months ago

@TrissyG

Integrated Strapi to our Navbar 🚀

In Strapi dashboard, I've added the following:

  1. Global Single Type
  2. Global Component

The footer can go in there and anything else that is rendered across the app that is not page/component specific 😃