search

UofS-Pulse-Binfo / analyzedphenotypes

Tripal/Drupal support for analyzed phenotypic data including data loaders, exporters, trait pages and summaries on germplasm pages.
GNU General Public License v2.0
0 stars 1 forks source link

Ready module for full release #122

Closed laceysanderson closed 3 years ago

laceysanderson commented 3 years ago

Bronze

Requirement Status
Has a public release. Yes
Should install on a Tripal site appropriate for the versions it supports. Yes (installed on KP and DivSeekCanada)
Defines any custom tables or materialized views in the install file (if applicable). Yes
Adds any needed controlled vocabulary terms in the install file (Tripal3). Yes
Provides Installation and admin instructions README.md (or RTD). Yes
Has a license (distributed with module). Yes

Silver

Requirement Status
Follows basic Drupal Coding standards; specifically, code format and API documentation. Yes
Uses Tripal API functions. Specifically, it should use the Chado Query API for querying chado (if using chado as the storage system). Yes
Tripal Jobs API for long running processes. Yes
TripalField class to add data to pages (Tripal3). Yes
Provides ways to customize the module (e.g. drush options, field/formatter settings, admin UI). Yes: cvterm, fields
Latest releases should follow Drupal naming best practices. e.g. first release for Drupal 7 should be: 7.x-1.x. Yes

Gold

Requirement Status
Extensive documentation for the module (similar to Tripal User’s Guide). Yes
Unit testing is implemented using PHPUnit with the TripalTestSuite or something similar. Yes
Continuous integration is setup (e.g. such as with TravisCI). Yes
Imports data via Tripal’s importer class (Tripal3). Yes
Tripal 3 fields are Fully compatible with web services. Yes
The elementInfo function is fully implemented. Yes
The query and queryOrder functions fully implemented. NA, doesn't make sense to search/sort on these fields
Web Services uses Tripal’s Web Service Classes (Tripal3). NA, no additional web services
Code sniffing and testing coverage reports (optional but encouraged). Yes
Drupal.org vetted release (optional but encouraged).
laceysanderson commented 3 years ago

PR made