UofS-Pulse-Binfo / analyzedphenotypes

Tripal/Drupal support for analyzed phenotypic data including data loaders, exporters, trait pages and summaries on germplasm pages.
GNU General Public License v2.0
0 stars 1 forks source link

Trait Distribution Chart Enhancements and Select Fields Not Working. #4

Closed reynoldtan closed 6 years ago

reynoldtan commented 6 years ago

Enhancements:

  1. Add spaces between rows in main page of trait distribution chart where it list genus followed by dataset count. This will clearly define one row from another.
  2. Emphasize Trait Distribution Chart link.
  3. Use Serif font for Genus (currently crop) column and change the 'crop' heading to 'Genus'.
  4. Use module's file structure.

Issues:

  1. Experiment select field does not filter list of trait options in trait select field. It filters the list when selecting a trait not specific to an experiment and clicking Generate Chart (causes An illegal choice has been detected. Please contact the site administrator. error). traits not updating
  2. After clicking Generate Chart to generate chart and going back to Select Dataset page, the experiment select field removes other experiments from the options. experiments missing
  3. Going back and forth the select dataset and summary chart adds // to the url. forward slashes
  4. In summary chart, select fields are nicely positioned adjacent to one another when character length of options in either fields is short, but causes the fields to stack one on top of another when for example the experiment name is longer than 15-20 characters. Trait select field gets pushed out of the fieldset.

select field

summary chart

laceysanderson commented 6 years ago

See original issue #2

laceysanderson commented 6 years ago

Fixed by PR