Closed laceysanderson closed 5 years ago
I was able to successful test this on a clone site! 🎉
I found the instructions unclear in terms of whether or not a header line was required in my input file. I initially tested without one and the job completed successfully but my 1 trait was not added to the system. In addition to updating the documentation, you could add a check for 1 line in the file and return an error... but this won't catch any cases with more than 1 trait being imported at a time - the user will end up with their 1st trait missing. You and I discussed checking for the header and I agree with you that the module shouldn't anticipate any specific text defining the header. Thus I think the only reasonable solution is to clearly warn the user that a header is necessary.
Thanks for the review!! I added a note about requiring a header to the UI.
Metadata
Documentation:
Description
This importer allows for easy uploading of trait dictionaries. This allows users with large datasets to pre-load the traits making it faster and easier to load phenotypic data for a large number of traits. This also makes it easier to test trait pages ;-p
Dependencies
This PR is dependent upon #62 because it needs to renamed
include
=>includes
directory in order for the importer to be found.Testing?
This importer has been tested both through the interface and using automated testing. To test it yourself:
NOTE: Make sure to clear the cache if the importer is not showing up.