UofS-Pulse-Binfo / analyzedphenotypes

Tripal/Drupal support for analyzed phenotypic data including data loaders, exporters, trait pages and summaries on germplasm pages.
GNU General Public License v2.0
0 stars 1 forks source link

Trait importer #63

Closed laceysanderson closed 5 years ago

laceysanderson commented 5 years ago

Metadata

Documentation:

Description

This importer allows for easy uploading of trait dictionaries. This allows users with large datasets to pre-load the traits making it faster and easier to load phenotypic data for a large number of traits. This also makes it easier to test trait pages ;-p

Dependencies

This PR is dependent upon #62 because it needs to renamed include => includes directory in order for the importer to be found.

screen shot 2019-02-18 at 5 18 09 pm

Testing?

This importer has been tested both through the interface and using automated testing. To test it yourself:

  1. Go to Admin > Tripal > Data Loaders > Phenotypic Traits
  2. Follow the instructions on the page to create a trait dictionary and choose an already configured genus.
  3. Run the job and check the trait chart or publish the page.

NOTE: Make sure to clear the cache if the importer is not showing up.

carolyncaron commented 5 years ago

I was able to successful test this on a clone site! 🎉

I found the instructions unclear in terms of whether or not a header line was required in my input file. I initially tested without one and the job completed successfully but my 1 trait was not added to the system. In addition to updating the documentation, you could add a check for 1 line in the file and return an error... but this won't catch any cases with more than 1 trait being imported at a time - the user will end up with their 1st trait missing. You and I discussed checking for the header and I agree with you that the module shouldn't anticipate any specific text defining the header. Thus I think the only reasonable solution is to clearly warn the user that a header is necessary.

laceysanderson commented 5 years ago

Thanks for the review!! I added a note about requiring a header to the UI.